Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search other platform folders for command if not found under current platform or common #96

Open
aidan-gibson opened this issue Jan 9, 2023 · 5 comments

Comments

@aidan-gibson
Copy link

tldr scriptreplay via c-client returns "this page doesn't exist yet" (of note, this also happens on https://tldr.ostera.io/)

Yet the node tldr returns the tldr page.

@MasterOdin
Copy link
Contributor

Relevant page: https://github.com/tldr-pages/tldr/blob/main/pages/linux/scriptreplay.md

What OS / distro are you on?

@owenvoke
Copy link
Member

owenvoke commented Jan 9, 2023

The web client works correctly, however as it's a Linux page, you have to prefix it.
https://tldr.ostera.io/linux/scriptreplay

@aidan-gibson
Copy link
Author

macOS Ventura 13.1

@MasterOdin
Copy link
Contributor

The C client will only look for a page for your current OS + common if you don't specify the --platform flag. The client spec does recommend this however:

If a page is not available for either the host platform or the common platform, then clients SHOULD search other platforms and display a page from there - along with a warning message.

The fix here would be to make the C client look at other platforms till it finds a page.

@MasterOdin MasterOdin changed the title tldr scriptreplay "This page doesn't exist yet" (exists using node client version) Search other platform folders for command if not found under current platform or common Jan 31, 2023
@jimmychang851129
Copy link

After analysis, I think the function to be enhanced is print_tldrpage,
I have started to work on it, can I take on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants