Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link canonical cascade #101

Open
simonpetry opened this issue Jun 1, 2020 · 1 comment
Open

Link canonical cascade #101

simonpetry opened this issue Jun 1, 2020 · 1 comment

Comments

@simonpetry
Copy link

First off, love the lib. Would there be some merit to cascading a <link rel="canonical" ... /> tag? (link tags aren't cascaded and for good reason)

But this particular link tag has a uniqueness requirement akin to title and other meta tags,
Multiple canonicals are ignored (this is old, but looks to be still relevant)

Specify no more than one rel=canonical for a page. When more than one is specified, all rel=canonicals will be ignored.

To bring this to a question: right now canonical is required to be set on every page, but should this be handled as an edge case and cascaded, or maybe there something a little more interesting here where we can leverage the platform and give any link tag the ability to cascade given a unique identifier via an id or class (or other) attribute?

One last thing, the canonical tag in the readme is using a content attribute but I think you want an href attribute: <Link rel="canonical" content="http://jeremygayed.com/" /> to <Link rel="canonical" href="http://jeremygayed.com/" />

Thank you for you time

@tizmagik
Copy link
Owner

tizmagik commented Jul 8, 2020

Interesting! What would a cascading a Link canonical look like? Would we just append them down the tree? 🤔

I guess we could support something like this by tweaking the cascade list here:

const cascadingTags = ['title', 'meta'];

Although it would need to be slightly more sophisticated than that if we only want to cascade <Link rel="canonical" /> and not other Link tags. But I'm curious to understand your use case a bit better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants