Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password in clear text if PASSWORD_HASH=auto and no password exists #21

Open
jmhauer opened this issue Feb 24, 2020 · 3 comments
Open

Comments

@jmhauer
Copy link

jmhauer commented Feb 24, 2020

The option PASSWORD_HASH=auto stores the password in clear text if no password is set before, because there is no Hash mechanism used if no password exists.
I think it would be a better way to use a standard Hash mechanism like SHA instead of using clear text. So the password is hashed, even if no password exists before.

@tiredofit
Copy link
Owner

This is an issue with upstream, recommend you change PASSWORD_HASH manually from Auto to something of your liking.

@jmhauer
Copy link
Author

jmhauer commented Mar 2, 2020

I changed it.
But I think for better security there should be no way, that the password is stored in plain text if it is not explicitly requested. Could be a security issue for someone who don't think about this behavior and PASSWORD_HASH is set to auto.

@tiredofit
Copy link
Owner

I'll add a warning in upcoming release when someone has the var set to auto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants