NestJS adapter

[talentlessguy]

Is your feature request related to a problem? Please describe.

An adaper for Nest will let you use tinyhttp inside of Nest instead of Express.

Describe the solution you'd like

A Nest.js adapter package, something like @tinyhttp/nest-adapter

Additional context

• NestJS platform-express
• nestjs-platform-polka

Please pull request to this repository

[ognjenjevremovic]

Hey @talentlessguy I see this issue is opened for quite some time.
I would like to see tinyhttp integrated with NestJS; do you mind if I take a closer look at this if it is not already implemented / worked on?

Also, I am wondering how would one test the underlying implementation of the mentioned adapter?
Should a dummy application be made (or perhaps taken from NestJS samples) or some sort of tests should be written to cover this implementation?
Do you have any guidelines / preferences about this?

[talentlessguy]

@ognjenjevremovic you could either create the separate repo with your own rights and else, or create a pull request

to test the implementation you can create an example in examples folder and of course write a bunch of unit tests

[talentlessguy]

if anyone wants to work on that, I'll create a new repo for NestJS

[KaviiSuri]

Hey, I'd love to give it a shot, but I'm kinda new to open source and was hoping for some guidance on how to do it?

[talentlessguy]

@KaviiSuri I'll create a new repo in the org and will assign you as a contributor

does this sound good for you?

[KaviiSuri]

Yeah, sounds good!!

Also, I'm new to tinyhttp and beginner with nestjs, so could you give me some resources to get started too?

[talentlessguy]

@KaviiSuri there's tinyhttp documentation website

regarding Nest, it's the same, I mean there is also docs

and also see links above for specific info

[KaviiSuri]

Okay, thanks, I'll get to it

[KaviiSuri]

Hey, I'm going through the docs and code samples you refrenced

As of now, it seems like I need to implement the AbstractHTTPAdapter interface along with creating a ITinyHTTPNestApplication interface that extends INestApplication

Is that it? Is there something I've missed?

[talentlessguy]

@KaviiSuri no idea, I haven't ever used Nest :/

[KaviiSuri]

Hey man, I'm not home this week, I'll start working the adapter the coming week. Just wanted to keep you in the loop.

[pSnehanshu]

Has there been any progress on the NestJS adapter @KaviiSuri? I am unable find the repo, @talentlessguy was it deleted or made private?

[KaviiSuri]

Hey @talentlessguy even I couldn't see the repo so I thought I shouldn't continue..
Anyway, i have enough time to contribute now, could you just create one so I could get started?

[talentlessguy]

@KaviiSuri made the package public https://github.com/tinyhttp/nest

[KaviiSuri]

Thanks, will get started on this asap.
I may need help on testing it though, I'll contact when I get to it.

[KaviiSuri]

Hey @talentlessguy , I started implementing the adapter and I need a little help.
How can I start tinyhttp with https?
I tried doing it with the standard https package from node but it doesn't respond with anything.
I was unable to find it in the docs

[pSnehanshu]

Why do you want to do that?

[talentlessguy]

@KaviiSuri HTTPS doesn't work in tests I think, it's a GitHub Actions issue

[KaviiSuri]

@pSnehanshu i actually need to support a nestjs option that turns on https.

@talentlessguy I actually don't need it tests, I just couldn't find how to do it with tinyhttp in an application too

[rubiin]

@talentlessguy can i work on it

[talentlessguy]

@rubiin yes

[rubiin]

I have a simple workable solution ready. Maybe you can publish the package under @tinyhttp/nestjs-platform-tinyhttp after i submit my pr

[talentlessguy]

@rubiin please do a PR to this repo