-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: able to abort git: push
or any other git operations
#1184
Comments
Shouldn't a failing hook abort the command by itself? |
Yes, at the very end after all the test suites are executed. I want to abort the tests as early as possible. |
Okay, I think that's straight forward to implement. If you have a What I would do: associate the current
Then for the panels, mark them as usual with a type e.g. It could be that after that |
In a project that I am working with, I have a pre-push hook that runs tests before pushing to upstream. The setting
live_panel_output
isTrue
so the test results are displayed on live. When something is wrong, I do wish to abort the hook and the test.It is not obvious to me how it could be implemented. Basically, we need to be able to run
p.kill()
for the git command subprocess. Though I am worried about thread safeness.The text was updated successfully, but these errors were encountered: