Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log pane scrolls to top when truncating #6381

Open
jnystad opened this issue May 24, 2024 · 0 comments
Open

Log pane scrolls to top when truncating #6381

jnystad opened this issue May 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jnystad
Copy link

jnystad commented May 24, 2024

Expected Behavior

Scroll (line) position is preserved (if possible), even when truncating logs.

Current Behavior

When LogStore triggers ensureMaxLength, and the log size is larger than max allowed, the LogUpdateAction.truncate is invoked, causing a resetRender in OverviewLogPane. This also resets the scroll position to start of logs when browsing the logs.

Steps to Reproduce

  1. Have a log pane open for something producing a lot of logs
  2. Scroll somewhere in the log stream (other than end and start)
  3. Wait until max log size is reached

Context

tilt doctor Output

$ tilt doctor
Tilt: v0.33.14, built 2024-05-15
System: linux-amd64
...

About Your Use Case

This makes log inspecting in tilt dashboard quite frustrating, and somewhat useless for containers with high log output.

Might be the cause of or related to #6096

@jnystad jnystad added the bug Something isn't working label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant