Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] support regex or start-with for checks #1078

Open
Borda opened this issue Aug 11, 2022 · 2 comments
Open

[FEAT] support regex or start-with for checks #1078

Borda opened this issue Aug 11, 2022 · 2 comments
Labels
feature New feature or request

Comments

@Borda
Copy link

Borda commented Aug 11, 2022

Is your feature request related to a problem? Please describe.
Having an option on how to group parametrized checks would very simplify the logic

Describe the solution you'd like
HAve simplification of using reg expressions so for example, instead of

    paths:
      - "dockers/**"
    checks:
      - "build-conda (3.8, 1.10)"
      - "build-conda (3.8, 1.9)"
      - "build-conda (3.9, 1.11)"
      - "build-conda (3.9, 1.12)"
      - "build-cuda (3.8, 1.9, 11.1.1)"
      - "build-cuda (3.9, 1.10, 11.3.1)"
      - "build-cuda (3.9, 1.11, 11.3.1)"
      - "build-cuda (3.9, 1.12, 11.3.1)"
      - "build-cuda (3.9, 1.9, 11.1.1)"

I would write only

    paths:
      - "dockers/**"
    checks:
      - r"build-conda (*)"
      - r"build-cuda (*)"

Describe alternatives you've considered
Or use it as a start with, so it could be:

    paths:
      - "dockers/**"
    checks:
      - r"build-conda"
      - r"build-cuda"

Additional context
readability is very important for larger projects...

@Borda Borda added the feature New feature or request label Aug 11, 2022
@carmocca
Copy link

carmocca commented Aug 11, 2022

I believe this is not currently supported by looking at the piece of code that checks satisfiability

checkName in checksStatusLookup &&
as there's no regex lookup

@tianhaoz95
Copy link
Owner

Yes currently it does not do a regex match, but it's definitely a good feature to have. I can probably take a look this weekend. Meanwhile, if you feel comfortable with the code base, it will be great to start some impl when you have time and I will review the code and get it in 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants