Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant syntax #44

Open
chihchenghuang opened this issue Jun 5, 2020 · 0 comments
Open

Remove redundant syntax #44

chihchenghuang opened this issue Jun 5, 2020 · 0 comments

Comments

@chihchenghuang
Copy link

little things.
I noticed you used virtual package in the alpine dockerfile.
As I know, once you use this feature, you don't have to list all packages in the apk del command.
apk del .build-deps should work perfect here.

https://github.com/tiangolo/uvicorn-gunicorn-docker/blob/master/docker-images/python3.7-alpine3.8.dockerfile#L7

more discussions:
https://stackoverflow.com/questions/46221063/what-is-build-deps-for-apk-add-virtual-command/46222036

Inpired a lot by your repo. good job man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants