Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I update the ./pleasew? #3068

Open
pauldruce opened this issue Feb 7, 2024 · 1 comment
Open

How do I update the ./pleasew? #3068

pauldruce opened this issue Feb 7, 2024 · 1 comment

Comments

@pauldruce
Copy link

I have noticed that the contents of the ./pleasew script have been updated.

A specific example is that the ./pleasew you get when using v17.7.0 by running plz init is different from that listed in this repo:
https://github.com/please-build/cc-rules/blob/master/pleasew - which looks like it was created

I would have thought plz update would also update the ./pleasew.

Should I be updating the ./pleasew at all?

@Tatskaari
Copy link
Member

Tatskaari commented Apr 2, 2024

Sorry, we seem to have missed this issue. I've updated ours manually by copy pasting from the pleasew in this main Please repo, but I think plz update could update the pleasew too. I've not got strong opinions about this to be honest. Feels a bit weird for plz update to make code changes for you, but I can see why it might be nice. Maybe plz init could have a flag for this? Would be happy to accept a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants