-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference to non-existent named output should be an error #2948
Labels
Comments
I had a crack at fixing this but it's quite a lot of work. It essentially requires a huge refactor of all the dependency resolution code. The annotated build labels are currently a concept of the build inputs, and are lost when we register dependencies to targets. I'll add this to the backlog, though we have some high priority work internally for the next quarter so might take a little time to get around to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A reference to a non-existent rule produces an error in Please. However, a reference to a non-existent named output just silently succeeds with no output. I would think that referring to a non-existent named output should fail with a similar error.
For example, given this BUILD file in the root of a project.
I get this behavior:
Note, when I try to build
//:bad-rule-ref
I get an error message, but when I build `//:bad-named-output-ref', it succeeds with the rule producing no output file. This can make a misspelling in a build file very hard to track down, since a misspelled named output won't produce any error at the actual source of the problem.The text was updated successfully, but these errors were encountered: