New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer: Add stroke trim API #2190

Closed

hermet opened this issue Apr 16, 2024 · 2 comments

Assignees

Labels

Milestone

Member

hermet commented Apr 16, 2024 •

edited

Stroke trimming is useful for artistic visuals including Lottie Animation.
ThorVG already has this feature built-in; it could provide the APIs for general usage:

Shape::strokeTrim(float begin = 0.0f, float end = 1.0f)

The text was updated successfully, but these errors were encountered:

hermet added the feature label

hermet added this to the 0.14 milestone

hermet changed the title ~~Renderer: Add stroke trim interface.~~ Renderer: Add stroke trim API

mgrudzinska self-assigned this

mgrudzinska added a commit to mgrudzinska/thorvg that referenced this issue


common: strokeTrim api introduced

43916f7

New api sets/gets the trim of the stroke
along the defined path segment, allowing
control over which part of the stroke is
visible.

@issue: thorvg#2190

mgrudzinska added a commit to mgrudzinska/thorvg that referenced this issue


common: strokeTrim api introduced

c94347b

New api sets/gets the trim of the stroke
along the defined path segment, allowing
control over which part of the stroke is
visible.

@issue: thorvg#2190

mgrudzinska mentioned this issue

common: strokeTrim api #2337

Merged

mgrudzinska added a commit to mgrudzinska/thorvg that referenced this issue


common: strokeTrim api introduced

5952e8a

New api sets/gets the trim of the stroke
along the defined path segment, allowing
control over which part of the stroke is
visible.

@issue: thorvg#2190

mgrudzinska added a commit to mgrudzinska/thorvg that referenced this issue


common: strokeTrim api introduced

153438a

New api sets/gets the trim of the stroke
along the defined path segment, allowing
control over which part of the stroke is
visible.

@issue: thorvg#2190

mgrudzinska added a commit to mgrudzinska/thorvg that referenced this issue


common: strokeTrim api introduced

83de97b

New api sets/gets the trim of the stroke
along the defined path segment, allowing
control over which part of the stroke is
visible.

@issue: thorvg#2190

Member Author

hermet commented Jun 1, 2024

see this: #2333

mgrudzinska added a commit to mgrudzinska/thorvg that referenced this issue


common: strokeTrim api introduced

2e98d3d

New api sets/gets the trim of the stroke
along the defined path segment, allowing
control over which part of the stroke is
visible.

@issue: thorvg#2190

hermet mentioned this issue

ttf_loader: support loading from memory #2345

Open

Member Author

hermet commented Jun 3, 2024 •

edited

Updated version:

Result Shape::strokeTrim(float begin, float end, bool simultaneous = true) noexcept;
bool Shape::strokeTrim(float* begin, float* end) const noexcept;

These API can be considered additionally if the trimming direction is properly introduced.
for example, allow the range -1 ~ +1 rather than 0 ~ 1
or additional parameter such as direction

mgrudzinska added a commit to mgrudzinska/thorvg that referenced this issue


common: strokeTrim api introduced

b96c26d

New api sets/gets the trim of the stroke
along the defined path segment, allowing
control over which part of the stroke is
visible.

@issue: thorvg#2190

mgrudzinska added a commit to mgrudzinska/thorvg that referenced this issue


common: strokeTrim api introduced

5b5050d

New api sets/gets the trim of the stroke
along the defined path segment, allowing
control over which part of the stroke is
visible.

@issue: thorvg#2190

mgrudzinska added a commit to mgrudzinska/thorvg that referenced this issue


common: strokeTrim api introduced

a448eed

New api sets/gets the trim of the stroke
along the defined path segment, allowing
control over which part of the stroke is
visible.

@issue: thorvg#2190

mgrudzinska added a commit to mgrudzinska/thorvg that referenced this issue


common: strokeTrim api introduced

2eb8c6e

New api sets/gets the trim of the stroke
along the defined path segment, allowing
control over which part of the stroke is
visible.

@issue: thorvg#2190

hermet pushed a commit that referenced this issue


common: strokeTrim api introduced

33f5ea3

New api sets/gets the trim of the stroke
along the defined path segment, allowing
control over which part of the stroke is
visible.

@issue: #2190

hermet closed this as completed

hermet pushed a commit that referenced this issue


common: strokeTrim api introduced

c7822cc

New api sets/gets the trim of the stroke
along the defined path segment, allowing
control over which part of the stroke is
visible.

@issue: #2190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment