Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lottie: Support the layer effect #2153

Open
theashraf opened this issue Apr 5, 2024 · 3 comments
Open

lottie: Support the layer effect #2153

theashraf opened this issue Apr 5, 2024 · 3 comments
Labels
feature New feature additions lottie Lottie animation
Milestone

Comments

@theashraf
Copy link
Member

Hey team

We've encountered an issue with the dotLottie players where a specific animation is not rendering. The main issue is documented here: LottieFiles/dotlottie-web#164.

I ran a Lottie features report using relottie on the mentioned animation and compiled a list of features it utilizes. It appears that ThorVG does not yet support the "layer effect" feature, which is used by this animation. Any suggestions on how to proceed?

Here is the list of features identified:

name
threedimensional
height
width
metadata
metadata-children
generator
composition
composition-children
layer-precomposition
layer-type
time-stretch
start-time
out-point
in-point
hidden
layer-threedimensional
blend-mode-normal
has-mask
auto-orient
layer-transform
layer-transform-children
anchor-point
animated-position
animated
position-keyframe-list
position-keyframe-list-children
position-keyframe
position-keyframe-out-tangent
keyframe-bezier-handle
keyframe-bezier-handle-x-axis
keyframe-bezier-handle-y-axis
position-keyframe-in-tangent
keyframe-value
keyframe-value-children
position-keyframe-time
layer-transform-scale
animated-multidimensional
keyframe-list
keyframe-list-children
keyframe
keyframe-out-tangent
keyframe-in-tangent
keyframe-time
layer-transform-skew
animated-value-static
static-value
translation
rotation-clockwise
animated-value
layer-transform-skew-axis
transform-opacity
reference-id
composition-index
layer-shape
effect-list
effect-list-children
effect-drop-shadow
effect-type
enabled
effect-param-list
effect-param-list-children
effect-param-color
effect-value-color
animated-color
effect-param-slider
effect-value-slider
effect-param-angle
effect-value-angle
shape-list
shape-list-children
shape-path
shape-type
shape-direction-clockwise
animated-shape-prop
animated-shape
shape-keyframe-list
shape-keyframe-list-children
shape-keyframe
shape-keyframe-out-tangent
shape-keyframe-in-tangent
shape-keyframe-start
shape-keyframe-start-children
bezier
bezier-closed
bezier-in-tangents
bezier-in-tangents-children
bezier-out-tangents
bezier-out-tangents-children
bezier-vertices
bezier-vertices-children
shape-keyframe-time
shape-fill
shape-fill-color
fill-rule-non-zero
shape-fill-opacity
version
framerate
assets
assets-children
asset-precomposition
id-asset-precomposition
shape-stroke
line-cap-butt
line-join-miter
miter-limit-value
stroke-opacity
stroke-width
shape-stroke-color

You can check the animation at this URL: https://lottie.host/c47dca0a-2580-41b8-b2e9-75a9aeeb017b/Ja2z677E9b.json

@theashraf theashraf added the lottie Lottie animation label Apr 5, 2024
@hermet hermet added the enhancement Improve features label Apr 6, 2024
hermet added a commit that referenced this issue Apr 9, 2024
Actually, the layer size is expected to be a floating-point value.
This correction addresses the parsing error.

issue: #2153
@hermet
Copy link
Member

hermet commented Apr 9, 2024

Unfortunately, we cannot use this resource at the moment due to the lack of support for "layer effects." We plan to support it, but it will take a few months. Perhaps, you can find an alternative method to convert this resource without relying on layer effects. For example:

  • Using a blurred shadow effect images beneath the leaf shapes.
  • Replace the effect with the additional shapes with radial-gradient filling beneath the leaf shapes .

@hermet hermet modified the milestones: 0.13, 1.0 Apr 9, 2024
hermet added a commit that referenced this issue Apr 9, 2024
Actually, the layer size is expected to be a floating-point value.
This correction addresses the parsing error.

issue: #2153
hermet added a commit that referenced this issue Apr 9, 2024
Actually, the these size is expected to be a floating-point value.
This correction addresses a parsing error.

issue: #2153
@theashraf
Copy link
Member Author

Thank you, @hermet, for the updates

hermet added a commit that referenced this issue Apr 11, 2024
Actually, the these size is expected to be a floating-point value.
This correction addresses a parsing error.

issue: #2153
@hermet
Copy link
Member

hermet commented Apr 18, 2024

another layer effect requirement: LottieFiles/dotlottie-web#181

hermet added a commit that referenced this issue Apr 19, 2024
Actually, the these size is expected to be a floating-point value.
This correction addresses a parsing error.

issue: #2153
@hermet hermet added feature New feature additions and removed enhancement Improve features labels May 1, 2024
@hermet hermet changed the title Lottie animation not rendering - potential lack of layer effects support lottie: Support the layer effect May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature additions lottie Lottie animation
Projects
Status: No status
Development

No branches or pull requests

2 participants