-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(bug) [relay-proxy] Override configuration via env variables in retrievers
does not work
#1841
Comments
Hi @thomaspoignant , I try to fix it, but I've found a bug in local, when I set yaml in the local:
the |
@luanxuechao from your example I see an indentation issue in your file on the providers. listen: 1031
pollingInterval: 1000
startWithRetrieverError: false
retriever:
kind: http
url: https://raw.githubusercontent.com/thomaspoignant/go-feature-flag/main/examples/retriever_file/flags.goff.yaml
retrievers:
- kind: file
path: examples/retriever_file/flags.goff.yaml
- kind: file
path: examples/retriever_file/flags.goff.yaml
exporter:
kind: log
enableSwagger: true
authorizedKeys:
evaluation:
- apikey1 # owner: userID1
- apikey2 # owner: userID2
admin:
- apikey3 Can you double check if this will solve your issue? |
Hi @thomaspoignant, it doesn't work. I run the relayproxy/main.go with |
@luanxuechao I've tried the same file as you and I don't reproduce.
|
@luanxuechao if you want you can also join the slack channel https://gofeatureflag.org/slack and we can discuss about your issue there. |
Observed behaviour
When running the relayproxy it is possible to override the configuration file using environment variables.
If the configuration to override is inside an array it is not possible to override it.
This is particularly true when dealing with secrets as mentioned in #1822.
With the current implementation of
koanf
this is not working well, we should consider following what is proposed in this issue knadh/koanf#74.Expected Behavior
We want to be able to override a property from the key retrievers with an environment variable.
Something like
export RETRIEVERS_0_HEADERS_AUTHORIZATION=Bearer xxx
The text was updated successfully, but these errors were encountered: