-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible bug in makeContent.shape when expand, radius= 0 #318
Comments
While there may be an issue buried somewhere in there I'm unsure whether the shapeGrob is the right tool for it. Any reason why you aren't using the grid::roundrectGrob? |
Hmm. Maybe I hadn't heard of it... though maybe there was another reason. I'll take the hint and look at it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm trying to use the new shapeGrob export on the "experiment-rounded-rect" branch of hughjonesd/ggmagnify. I ran into an error, which I now can't reproduce, like this:
corners
is passed into theradius
argument toshapeGrob
.This did give the error:
though now it seems to be ok :-/
Anyway, it seemed to happen when the
radius
andexpand
variables inmakeContent.shape
evaluated to 0 via the code inconvertWidth
(perhaps because of a small viewport?) If so, then the variouspolyoffset
functions inmakeContent.shape
aren't called, and then thepolygons
variable ends up not set up correctly for some reason.I'm sorry, this isn't a very useful bug report! But you might be able to understand what's happened better than me and work out a test case for this code path.
The text was updated successfully, but these errors were encountered: