Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing http_build_query to drupal_http_build_query to make it work … #89

Closed
wants to merge 1 commit into from
Closed

changing http_build_query to drupal_http_build_query to make it work … #89

wants to merge 1 commit into from

Conversation

xenosenem
Copy link

Fix #88 : Changing http_build_query to drupal_http_build_query here to make it work with php 5.4 when getting templates:

  case 'GET':
    $uri .= '?' . drupal_http_build_query($parameters);
    break;

@xenosenem xenosenem mentioned this pull request Jun 11, 2019
Merged
@torgospizza
Copy link

I don't think this is the right approach; as this PHP Library is not a Drupal module, it should not include a Drupal-specific function call.

@ruscoe
Copy link
Contributor

ruscoe commented Jun 16, 2019

If I'm understanding issue #88 correctly, it might be an option to use str_replace() to replace & with &.

@mortenson
Copy link
Contributor

I agree with @torgospizza, this library is not Drupal specific.

@mortenson mortenson closed this Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameter issue with php 5.4
4 participants
@xenosenem @torgospizza @ruscoe @mortenson