Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub enterprise support #10

Open
ivey opened this issue Mar 19, 2014 · 5 comments
Open

GitHub enterprise support #10

ivey opened this issue Mar 19, 2014 · 5 comments
Labels
enhancement

Comments

@ivey
Copy link

ivey commented Mar 19, 2014

It would be great if I could add my GH:E URL to the matches. I don't know anything about Chrome Extensions, but I'm going to dig in and see if I can figure it out.
@stephenmathieson
Copy link

you probably just need to edit these, but i don't know anything about github enterprise

@ivey
Copy link
Author

ivey commented Mar 19, 2014

So, I can add an options page, but it won't be able to change the manifest, and will require using programmatic injection to selectively enable the extension at runtime on the page, and will require cross-domain permissions on every site.

Probably not worth it. I will keep poking though, and maybe I will find something.

@jphastings
Copy link

If you're able to add permissions to a site based on tags on the page both GH:E and standard Github have this tag set in their <head>:

<meta content="GitHub" property="og:site_name">

You could give it permissions for all sites and match on *://*/*/compare/* and do a check in the code to figure out if there's a /html/head/meta[property='og:site_name'] tag, but that feels a little nasty?

@thieman thieman mentioned this issue Aug 28, 2014
Closed
@gtallen1187
Copy link

Not sure if this is still being considered, but just in case, i'd like to add in a vote for GitHub enterprise support.

If it's helpful, this chrome extension seems to do a pretty decent job of supporting both github.com and enterprise options.

@tal
Copy link

tal commented Jun 8, 2017

This extension also does github + enterprise https://github.com/thecodejunkie/github.expandinizr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ivey @tal @jphastings @stephenmathieson @thieman @gtallen1187