-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reopen index.html when I close it? #1135
Comments
There is no such thing as opening a browser for any regular build at the moment. Your editor might attempt it, but shadow-cljs does not as this would require an additional config option. I'm fine with adding something like I'm fine with printing something too, you can set All information related to REPL connects/disconnects is available for everyone that is interested in it. Just currently only exposed via shadow remote and severly underdocumented. Nobody had any interest in the version accessible over nrepl so far, it does still exist and maybe cider wants to make use of it? |
Thanks for the response!
CIDER already prints a variety of possible shadow-cljs messages (while doing no special effort at accomplishing so), while staying on the default log level: Therefore, it would seem easy, and consistent with the rest of the existing experience to print a
Nice. If I appreciated, I could offer a PR with that. At this point I would be happy with a simple println though. I don't like suggesting/introducing heavier changes untill I consider my need fully time-proven. Cheers - V |
A quick hack would be adding that log here
If Not sure that's where I'd want it to be ultimately but could be an option. |
I have the pretty severe muscle memory of closing Chrome tabs.
With it, I can close index.html, and with it, my IDE experience will significantly degrade.
I can spend a while realising the cause of this.
So, perhaps there could be an option such that on disconnect, the shadow-cljs would print
shadow-cljs disconnected.
or so.Even better, it could be a plugable function so that I can
(clojure.java.shell/sh "open" "index.html")
instead.Don't know if this is there already / a FAQ, etc.
Thoughts?
Thanks - V
The text was updated successfully, but these errors were encountered: