Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing image_to_url replicas back to 1 does not update HPA #37

Open
geckofu opened this issue Jul 21, 2021 · 2 comments
Open

Changing image_to_url replicas back to 1 does not update HPA #37

geckofu opened this issue Jul 21, 2021 · 2 comments

Comments

@geckofu
Copy link
Member

geckofu commented Jul 21, 2021

How to replicate:

Passing replicas=2 to an image_to_url() function, this will create an HPA along with other resources.
Then set the replicas argument to 1, the deployment replica is updated but not the HPA.

Relevant code:

plantbuild/jsonnetlib/k8s.jsonnet

Line 358 in 82324bb

] + if replicas > 1 && maxReplicas > 1 then [

@idealhack
Copy link
Member

do you have a more complete step to reproduce this? a failed test case would great!

@idealhack
Copy link
Member

Now that I'm reading this again, it's actually the same as not supporting deleting resources, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@idealhack @geckofu