-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token from storage should expire but hasExpired always returns false #942
Comments
Me and my buddies were checking this situation and we found out that instead of saving the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm using OAuth 2 with Forge Autodesk, they usually return tokens with
expires_in: 3599
.If I get a token from storage and run
$accessToken->hasExpired()
always return false, because on the construct the expiration date is calculated withtimeNow + expires_in
.With this logic, the token will never expire, which is incorrect.
The text was updated successfully, but these errors were encountered: