Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of types #91

Open
decibel opened this issue Oct 27, 2015 · 3 comments
Open

Improve handling of types #91

decibel opened this issue Oct 27, 2015 · 3 comments

Comments

@decibel
Copy link
Collaborator

decibel commented Oct 27, 2015

This affects the function tests (IE: function_owner_is), but might impact others.

The current API of passing in a name is problematic because if you pass in a non-canonical type name (ie: int) you end up with a very confusing 'function does not exist' error. It would be better if we were dealing with regtype[].

Any significant downsides to changing the parameters of the function_* test functions? FWIW, regtype[] exists back to at least 9.0.

@theory
Copy link
Owner

theory commented Oct 27, 2015

No, I think that would be fine, as long as we updated compat/install-8.4.patch to switch it back to NAME[].

@decibel
Copy link
Collaborator Author

decibel commented Oct 28, 2015 via email

@theory
Copy link
Owner

theory commented Oct 28, 2015

pgTAP has patch files for support back to 8.1. I dropped 8.0 back in Nov 2011, so I'd say we could start dropping the other 8.x versions. Hasn't really been a reason to since then, though. If the change is just to the signature (regtype[] instead of name[]), then it will be easy for me to update the patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants