Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pgtap_version() from numeric? #210

Open
decibel opened this issue Sep 16, 2019 · 2 comments
Open

Change pgtap_version() from numeric? #210

decibel opened this issue Sep 16, 2019 · 2 comments

Comments

@decibel
Copy link
Collaborator

decibel commented Sep 16, 2019

Now that we're past 1.0.0, it'd be helpful to be able to do patch releases (ie, to fix issue #209). We can't do that with pgtap_version returning numeric, unless we want to have it return something like 1.001?

@theory
Copy link
Owner

theory commented Sep 17, 2019

PGXN supports only semantic versions, so 1.001 is not allowed.

@theory
Copy link
Owner

theory commented Sep 17, 2019

Sorry, was reading too quickly. Please don't change its return value, that would break compatibility. The value is set by the $NUMVERSION variable in the Makefile. I think the idea was that it would return only the first two parts of the version, because the patch version (the third part) should indicate only the simplest of bug fixes, without changing any functionality. But also, we've never released a version with anything other than 0 in the version patch level. So maybe just stick to that pattern and release 1.1.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants