Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split pgtap.sql.in #170

Open
rodo opened this issue Jun 22, 2018 · 1 comment
Open

Split pgtap.sql.in #170

rodo opened this issue Jun 22, 2018 · 1 comment
Assignees
Labels

Comments

@rodo
Copy link
Contributor

rodo commented Jun 22, 2018

Will you be agree to split the huge pgtap.sql.in in some smaller parts ?
It could be done with few impact,

  • split the files in some parts
  • add a Makefile target to build the file pgtap.sql.in

It will help a lot to maintain it over time and had new functionnalities

@decibel
Copy link
Collaborator

decibel commented Jun 23, 2018

IMHO, it'd be better to give each function it's own file (based on name, not name+args). That means an upgrade script would be essentially a bunch of \i's, and could probably be generated dynamically based on a git diff.

I got so far as cobbling together a script to split things out: https://github.com/decibel/pgtap/blob/split_funcs/funcfiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants