Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No warning for use of @html tag in Components #1282

Open
JannisKoeksel opened this issue Mar 19, 2024 · 2 comments
Open

No warning for use of @html tag in Components #1282

JannisKoeksel opened this issue Mar 19, 2024 · 2 comments

Comments

@JannisKoeksel
Copy link

Describe the bug

Some components use the @html tag (e.g. Timeline Activity) without proper warning.

Reproduction

Not needed

Flowbite version and System Info

latest
@shinokada
Copy link
Collaborator

What kind of warnings are you expecting?

@JannisKoeksel
Copy link
Author

A notice in the docs would be useful.
In general, having the HTML render as an opt-in instead of it being the default is in my opinion a better approach.
Not sure how you would handle backwards compatibility in that case.

To preserve backwards compatibility:

  • add an htmlRender boolean prop
  • if it is not specifically set, print a warning if in dev environment

shinokada added a commit that referenced this issue Apr 19, 2024
@shinokada
docs: #1282 add warnings in the docs where components are using @html
572888c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shinokada @JannisKoeksel