Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEPR] pick_fastest needs to return None instead of empty Lap #477

Open
theOehrly opened this issue Nov 9, 2023 · 1 comment
Open

[DEPR] pick_fastest needs to return None instead of empty Lap #477

theOehrly opened this issue Nov 9, 2023 · 1 comment
Labels
deprecation Concerns a pending deprecation maintenance Changes required to gurantee that things work properly in the future still
Milestone
v3.5.0

Comments

@theOehrly
Copy link
Owner

Laps.pick_fastest currently returns an empty Lap object in case there is no lap or no lap that meets the criteria for fastest lap.

Starting from v3.3 this should return None instead. The corresponding deprecation warning was added in #476.

See also: #472, #472 (comment)

This issue serves as a reminder to change this for v3.3
@theOehrly theOehrly added maintenance Changes required to gurantee that things work properly in the future still deprecation Concerns a pending deprecation labels Nov 9, 2023
@theOehrly theOehrly added this to the v3.3.0 milestone Nov 9, 2023
theOehrly added a commit that referenced this issue Feb 19, 2024
@theOehrly
MNT: make pick_fastest return None instead of empty lap following dep…
4aeb91a 
…recation (closes #477)
@theOehrly theOehrly modified the milestones: v3.3.0, v3.4.0 Feb 19, 2024
@theOehrly
Copy link
Owner Author

Change delayed because a DeprecationWarning was accidentally used (not shown to users by default) instead of a FutureWarning (shown to users by default).

theOehrly added a commit that referenced this issue Feb 19, 2024
@theOehrly
MNT: change DeprecationWarning to FutureWarning (#477)
ed4f851
@theOehrly theOehrly modified the milestones: v3.4.0, v3.5.0 Feb 19, 2024
theOehrly added a commit that referenced this issue Feb 20, 2024
@theOehrly
MNT: change DeprecationWarning to FutureWarning (#477)
a2a82d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecation Concerns a pending deprecation maintenance Changes required to gurantee that things work properly in the future still
Projects
None yet
Milestone
v3.5.0
Development

No branches or pull requests
1 participant
@theOehrly