Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShowList funtion in DRY section does not return a list #113

Open
mdgr3301 opened this issue Apr 11, 2022 · 1 comment
Open

ShowList funtion in DRY section does not return a list #113

mdgr3301 opened this issue Apr 11, 2022 · 1 comment

Comments

@mdgr3301
Copy link

ShowList funtion should return an object of List, currently does not return anything

public List ShowList(Employee employees)
{
foreach (var employee in employees)
{
var expectedSalary = employees.CalculateExpectedSalary();
var experience = employees.GetExperience();
var githubLink = employees.GetGithubLink();
var data =
new[] {
expectedSalary,
experience,
githubLink
};

    render(data);
}

}

@dmitryvhf
Copy link

dmitryvhf commented Apr 12, 2022

currently does not return anything

All examples do not return a result and should not return.
So, error in samples signatures - need change from List to void.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants