Preferences panel: problematic labels (disconnected from their respective input fields)

[phiw13]

1/ Missing ID under Advanced options - “Custom form template” and “file_download_header”

<label for="custom_form_types">Custom form template types&nbsp;<a rel="help" title="Help" role="button"[…] >Help</span></a></label> 

<label for="file_download_header">file_download_header</label>

--> The for attribute for both <label />s are referencing a non-existing ID – the relevant <textarea /> only specifies a name attribute, no id.

2/ In other Preferences sub groups (Site and Mail)

Two fields with similar problem: <label /> should not be used here (the radio buttons have a <label /> on the “Yes/No” text), but it probably could use aria-labeled-by as suggested in an other issue)

<label for="trailing_slash">Add a trailing slash to URLs</label>

<label for="enhanced_email">Use enhanced mail features?</label>

[bloatware]

1. is easy to fix, 2) is more annoying.

[phiw13]

@bloatware – Your temp. fix works fine for both issues, as far as I can see. Thanks for that.

As you labeled it “temp” I assume there is some more work that can or should be done?

[bloatware]

Yes, the second point should be fixed more properly. Currently, all pref input handler names (like yesnoradio) that do not require a common label are hard-coded. As soon as a (new) pref uses a custom handler that is not on the list (like trailing_slash), it gets labelled.