Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery 4.0.0 is coming soon #1896

Open
petecooper opened this issue Dec 26, 2023 · 13 comments
Open

jQuery 4.0.0 is coming soon #1896

petecooper opened this issue Dec 26, 2023 · 13 comments

Comments

@petecooper
Copy link
Member

jquery/jquery#5365 (comment)

Placeholder issue for jQuery 4.0.0 compatibility / issues.

@petecooper
Copy link
Member Author

@bloatware
Copy link
Member

Thanks @petecooper. It looks like we are hold by jQuery file uploader that uses few removed methods.

@bloatware
Copy link
Member

My local txp runs jQuery 4 beta, so far so good. Should we try using it in dev, to enlarge the testers pool? We'd switch back to jQuery 3 of course if txp 4.9 is released before jQuery 4.

bloatware added a commit that referenced this issue May 24, 2024
@bloatware bloatware added this to the v4.9 milestone May 24, 2024
@bloatware
Copy link
Member

Demo server is blocking something, not sure what.

@petecooper
Copy link
Member Author

I can have a look - what can you see?

@bloatware
Copy link
Member

Not able to save an article, for example. This shouldn't be directly related to jQuery 4 since it works on my localhost.

@petecooper
Copy link
Member Author

petecooper commented May 24, 2024

Refused to execute https://dev-demo.textpattern.co/dev/textpattern/index.php?_=1716559654637 as script because "X-Content-Type-Options: nosniff" was given and its Content-Type is not a script MIME type.

Might that be it?

Edit: console output when saving a (new) article.

@bloatware
Copy link
Member

Yep, it looks like a csp conflict. Ironically, jQuery 4 intends to solve them.

@petecooper
Copy link
Member Author

I'll see how I can workaround it in the meantime, leave it with me for now.

@petecooper petecooper self-assigned this May 24, 2024
@petecooper
Copy link
Member Author

I'm a little perplexed - this appears to be solved, yet I haven't changed anything. Are you able to reproduce, @bloatware?

@bloatware
Copy link
Member

@petecooper oops, sorry, I thought you have seen. We'd rather do some tests locally before pushing it online.

@petecooper
Copy link
Member Author

Now seen 👍

@phiw13
Copy link

phiw13 commented May 27, 2024

I can of course reproduce the issue when the X-Content-Type-Options "nosniff" header is present. Once that is disabled (header unset … in textpattern/.htaccess), I still have saving issues on the Write tab (actually, no way to Save anything, old or new article) – both my old test site and a newish fairly default installation.

The Firefox console reports:

As a warning
The script from “http://txpdev.local/textpattern/index.php?_=1716781530549” was loaded even though its MIME type (“text/html”) is not a valid JavaScript MIME type.

As an error:
Uncaught SyntaxError: expected expression, got '<' (index.php 1:1)

I suspect there is some attempt at setting a response header that fails

–^–

All other panels behave correctly as far as I can see, images/files are uploaded or replaced, categories created, preferences saved. The few admin-side plugins active do what they are supposed to… etc. This testing with a fairly strict set of CSP directives (in config.php)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants