-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-node-access
to report where fireEvent/userEvent could be used
#752
Labels
enhancement
New feature or request
Comments
zaicevas
added
enhancement
New feature or request
triage
Pending to be triaged by a maintainer
labels
Apr 12, 2023
Hi @zaicevas. It sounds like an excellent idea, actually. Not sure if fits better in this rule, or in a new one. Still, would be nice to report this. Are you up to work on it? |
I'll try to evaluate the complexity and let you know :) |
Apologies for late answer, but I don't have capacity right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What rule do you want to change?
no-node-access
Does this change cause the rule to produce more or fewer warnings?
More warnings
How will the change be implemented?
Not sure regarding the versioning (major/breaking change), but the idea behind this is that
userEvent
orfireEvent
usage should be preferred over direct node access to call events, such as.focus()
,.click()
. We could have a whitelist of methods that would be reported by the rule.Example code
How does the current rule affect the code?
No error reported
How will the new rule affect the code?
Report an error
Anything else?
No response
Do you want to submit a pull request to change the rule?
No
The text was updated successfully, but these errors were encountered: