Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown rendering issue when using theme-id: 300 (Terminal) #1884

Open
Didas-git opened this issue Mar 27, 2024 · 2 comments
Open

Markdown rendering issue when using theme-id: 300 (Terminal) #1884

Didas-git opened this issue Mar 27, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Didas-git
Copy link

I was writting some note in markdown and i came accross this weird issue where the last word doesnt get rendered, it adds the space for the word but not the word itself.

I have a really small reproduction of this on the playground

And i will leave a screenshot attached for clarification as well.
image

@alixander alixander added the bug Something isn't working label Mar 27, 2024
@alixander
Copy link
Collaborator

dev notes:

It's the mono rule in the theme that's effecting it. I've inspected the pre-processisng code in d2graph and the some of the code in textmeasure. Can't find anything amiss. Even adding +1 to the width makes enough room. But this can't be reproduced unless it's mono font, so it must be something to do with that condition only.

There's some things we do in textmeasure that's "for code only". It doesn't affect code block shapes because their measurements don't need to be as precise (there's padding). That was customized some, so maybe something we did there is off-by-one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants