-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modules invoked with missing required parameters #1186
Comments
Thanks for your report of this issue. The Terraform configuration is valid as validated by Regarding the list of missing required variables in the screenshot most of then are not part of the project-factory module variable list like For the ones that are part of the module like https://github.com/terraform-google-modules/terraform-google-project-factory/blob/v14.0.0/variables.tf#L34C1-L38C2 The official Terraform documentation regarding input variables, states that variables with a default value are optional (not required) Reported behavior looks like an issue in the the configuration of the VSCode extension for Terraform, Updating the VSCode extension for Terraform to use the latest release should be able to solve this issue. |
Thanks Daniel, I agree with this explanation that it looks like a configuration issue on the IDE and not a bug in this repo's code. I'll close this issue, please re-open if there are further concerns. |
TL;DR
When invoking some library modules required parameters not passed. It might work if the declared parameters (in variables.tf of the module) endup by actually not being used for reasons of "example" code or disabled sections. But not sure what is the general opinion regarding this coding practice, which I would abstain to qualify in my own words.
See as an example (among many) the attached screenshot exemplifying a call to project-factory with missing required parameters in 1-org/envs/shared/projects.tf.
Expected behavior
Required parameters with valid values should be passed to the modules requiring them, regardless whether actually being used in a particular instance of a module
Observed behavior
The deployment "seems" to work although with many warnings - can't tell anything about actual vs expected resources being deployed
Terraform Configuration
Terraform Version
terraform version Terraform v1.6.0 on linux_amd64 Your version of Terraform is out of date! The latest version is 1.8.0.
Additional information
The text was updated successfully, but these errors were encountered: