deal with EBS options properly

[hakamadare]

right now if ebs_volume_size is set to 0, then ebs_enabled is set to false, and then there's an error message about how we can't pass any EBS options.

[ghost]

@hakamadare Could you describe this bug more precisely?

[mikhail-bardash]

If ebs_enabled is set to false, volume_sizeshould be ignored, but it's still failing(see error below) even if you set volume_size = 0.

    ebs_options {
    ebs_enabled = "${var.ebs_volume_size > 0 ? true : false}"
    volume_size = "${var.ebs_volume_size}"
    volume_type = "${var.ebs_volume_type}"
  }

Error: Error applying plan:

1 error(s) occurred:

• module.redis.aws_elasticsearch_domain.es: 1 error(s) occurred:

• aws_elasticsearch_domain.es: ValidationException: EBSEnabled must be set to true to use any of the EBS options.
  status code: 400, request id: 598e63f6-3cd3-11e8-a443-2f0600b15d39

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

[Tiny-wlx]

+1

[okleinschmidt]

+1