Documentation about default for enable_irsa is incorrect.

[thehandsomezebra]

Description

enable_irsa is documented as default false BUT Actual enable_irsa is actually default true

sources for where it states false:

• https://registry.terraform.io/modules/terraform-aws-modules/eks/aws/latest/submodules/karpenter?tab=inputs
• https://github.com/terraform-aws-modules/terraform-aws-eks/blob/v20.8.4/modules/karpenter/README.md?plain=1#L138
• More info on how to jump from 19->20 here, meaning this should be default false https://github.com/terraform-aws-modules/terraform-aws-eks/blob/v20.8.4/docs/UPGRADE-20.0.md?plain=1#L197-L215

sources for where it states true:

• https://github.com/terraform-aws-modules/terraform-aws-eks/blob/v20.8.4/variables.tf#L389-L393
• https://github.com/terraform-aws-modules/terraform-aws-eks/blob/v20.8.4/README.md?plain=1#L298

If your request is for a new feature, please use the Feature request template.

• ✋ I have searched the open/closed issues and my issue is not listed.

Versions

• Module version [Required]: 20.8.4 (not certain if this appears in other versions, but likely it does)

Reproduction Code [Required]

Steps to reproduce the behavior:

1. Read documentation.
2. Expect enable_irsa to be default false and do not define it.

Expected behavior

enable_irsa is set to false.

Actual behavior

enable_irsa is set to true.

Additional context

As I am currently working on 20.8.4, I can confirm that this is here -- however I can only assume that this has persisted since 20.x has come along.

[suminhong]

Hmm well.
The default value of enable_irsa of "eks module" is true, but the default value of enable_irsa of "karpenter submodule" is only false.
The two are different.

[thehandsomezebra]

Hmm well. The default value of enable_irsa of "eks module" is true, but the default value of enable_irsa of "karpenter submodule" is only false. The two are different.

Good point -- hadn't realized that at first.

I think what led me down that being a discrepancy was the upgrade notes.

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days