Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create aws_eks_pod_identity for Karpenter #6

Closed
matheusmazzoni opened this issue Apr 17, 2024 · 4 comments
Closed

Create aws_eks_pod_identity for Karpenter #6

matheusmazzoni opened this issue Apr 17, 2024 · 4 comments

Comments

@matheusmazzoni
Copy link

matheusmazzoni commented Apr 17, 2024

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

  • Yes ✅: Included since 5.29.0 (November 30, 2023)

Is your request related to a problem? Please describe.

I think it would be interesting to have a template for karpenter as well. I'm currently updating to version 20.8 of the EKS module and I wanted to use my karpenter with pod-identity, because my kube-system run in EC2 Nodes. So, I need to make the association and iwould be interesting use this module.

Describe the solution you'd like.

The idea would just be to create a template with the necessary policy to make the association for karpenter.

Describe alternatives you've considered.

I see two alternatives:

  1. Create an implementation for karpenter here: Make the implementation based on the examples here
  2. Modify the karpenter sub-module within eks: Implement pod-identity within the sub-module terraform-aws-eks/modules/karpenter

If you prefer, I can implement on both repos 😄!

@matheusmazzoni
Copy link
Author

@bryantbiggs and/or @antonbabenko
Could you verify this issue? Because if you point me in the right direction I can create it either here or in the eks submodule :D

@bryantbiggs
Copy link
Member

right now the recommendation for aws_eks_pod_identity_association with Karpenter is to use the direct resource as needed

@bryantbiggs
Copy link
Member

the Karpenter sub-module supports creating the association now so closing out this issue terraform-aws-modules/terraform-aws-eks#3031

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants