New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touchpad right-click cancel and two-finger gesture axis inversion issue #419
Comments
Your log is taken from version without some debugging lines. Try to reproduce the same movements with this: |
@Giova445 can you please make the same thing? |
I am using Xperia 5 ii and when I capture the physical mouse the X and Y are flipped |
In this APK, the symptoms of reversing the x and y axes appear again as in the past. This is the log file. |
@Rmtdi do the same thing. |
Give me some details. |
After using that version apk, my problem was fixed :), and I don't know how to get the log file, this file doesn't look right, hope it helps. |
@twaik here's the log, I've tested so far with the build Making termux-x11 command work on Android 14+ (termux/termux-packages… but I'm still having the two-finger axis inversion issue, tested on galaxy tab s7+ |
@Giova445 that is probably because I did not commit the fix. I stil can not reproduce it on my local devices and changes I made to fix it most likely break compatibility for other devices. I should test real touchpad and after that I will make some other changes... |
@AlphaBs can you please check if you can fix this? |
I see you've added a new option and I can't wait to try it, but I'm currently unable to use my device for about two weeks for security reasons. 😭 |
@hansm629 Is |
@twaik |
Also you can check the new preference "transform captured pointer movements". |
It is not a fix, but at least you can make your touchpad behave more predictable. |
|
I'm going out for a while right now. |
@hansm629 this issue is the last one. |
As of latest #597 build If you adjust the The touchpad on the keyboard cover not applied and the mouse point axis is reversed, making it impossible to use normal gestures.
2024_04_02.01_31.mp42024_04_02.01_31.1.mp4 |
@twaik |
I did not really understand this sentence. Can you please tell it in other words? |
@twaik This means that the new |
@AlphaBs how do you think, can we make DexListener's GestureDetector use standard practices for detecting gestures like single and doubletap? Currently it is limited to scrolling detection. |
I don't think that GestureDetector can handle the custom flags which Samsung touchpad produces, but I will test it later. and 'double tap', I can't see any differences between double tap event and single tap event on my device. no special flag, no classification. it just reports normal single tap event but twice. |
I encountered the same flipped pointer axis issue in Dex mode when I use my Samsung Fold 5 phone as trackpad in landscape orientation (it's normal in portrait orientation). Even worse, the left click does not work at all. If developers do not own a Samsung device or cannot reproduce, I could record log and post it. Thank you. |
Recording log will not help. I must have an ability to test things in real time. |
I am happy to help but I'm very unfamiliar with your code. Could you give me hint on which file I should begin with for this matter? |
|
@hansm629 I made a pull request at #617 to fix the issue. See if you may want to try (as I don't own a pad with physical touchpad). An automatically built APK is available on the github action: https://github.com/termux/termux-x11/actions/runs/8864550086. You will want to choose |
@knyipab The touchpad of the Galaxy Tab S9 Ultra keyboard cover is not inverted. but 2024_04_28.13_28.mp4Please check~ |
@hansm629 If that's the case, a log by |
@knyipab I have a same issue on Galaxy Tab S8+ bookcover keyboard. here is the log:
|
@knyipab it only occurs when 'Transform captured pointer movements' is set to 'Automatic'. |
Thanks a lot. I see why. I own a folding device which has two screens and I usually use my unfolded screen (i.e. displayID=1) as touchpad. So I hardcoded that into code, but that does not exist for tablets. I think the right approach would be testing from display=0 to higher number whether the screen is ON. It's not diffcult but I went outdoors. Will fix it, probably later tomorrow. |
As promised, I updated my pull request and you may try the new automatic build at https://github.com/termux/termux-x11/actions/runs/8882154871. I suppose |
@knyipab Termux-x11 does not crash with the automatic setting, but For older versions of the apk, although Termux-x11 crashed. |
@knyipab it works with automatic mode. the poitner speed is normal on my device. (100% captured pointer speed) |
@hansm629 Few things to note
@AlphaBs (and @hansm629)
The complication lies on different beharviour across soft and hard touchpad. In my apk build, the touchpad is handled the same way as touchscsreen, i.e. |
Yes. All touch gestures like tapping, scrolling, dragging work perfectly. Only the physical click does not work.
It's same regardless of the option.
I think so. I recorded touch events before maybe this would help: #587 |
@AlphaBs Thanks. Implemented |
@knyipab I tested it with the newly built apk. (Setting: Automatic) Galaxy Tab S9 Ultra Keyboard Cover Touchpad The point speed is too fast, making precise use difficult. Even if you manually adjust the point speed, it is not reflected. |
Fixed with most recent commit (apk build here). The option Nonethelss, there is another pointer speed issue (even for current Termux:x11 build, not a problem of PR#617). On my device, the speed of touchpad pointer and hardware mouse pointer are similar before capture, but after being captured, the touchpad speed is way faster comapred to hardware mouse. My gut feeling is that Android (or vendor) probably scale touchpad and mouse raw offsets at different factors. There seems no easy fix other than introducing a new speed option for captured touchpad, but not sure if that is welcomed by this project. |
@knyipab thank you! it works perfectly with my device |
Thank you for the new build.
Most of the Galaxy Tab S8+ keyboard cover touchpad compatibility is improved in the latest build. :)
Reports additional symptoms identified during the test.
SHANA.20230808_214102.mp4
1. touchpad right-click cancel
If you click right on the touchpad, the click result seems to be canceled. (Video 00:09~00:20)
2. two-finger gesture axis inversion issue
Two-finger gestures confirmed the symptoms of reversing the axis when moving up, down, left, and right. (video 00:22~00:30)
log_20230808.txt
The log file is here.
The text was updated successfully, but these errors were encountered: