Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: libosmpbf can not be rebuilt or upgraded #20124

Closed
twaik opened this issue May 13, 2024 · 5 comments
Closed

[Bug]: libosmpbf can not be rebuilt or upgraded #20124

twaik opened this issue May 13, 2024 · 5 comments
Labels
bug report Something is not working properly. packaging Issue related to building packages, not affecting end users directly.

Comments

@twaik
Copy link
Member

twaik commented May 13, 2024

Problem description

I failed to rebuild or upgrade libosmpbf.

What steps will reproduce the bug?

./build-package.sh -I -f libosmpbf gives me this log:
log.txt
It seems like it is not compatible with abseil-cpp source but I am not so sure about it.

After updating libosmpbf to 1.5.1 with SHA256=edd98ba252c81372113747a131466f5ba45e0cff97b597e863a26e83943ba84f I am getting different log:
log2.txt
It seems like it fails to find protobuf generator binary.

What is the expected behavior?

N/A

System information

N/A

@twaik twaik added bug report Something is not working properly. untriaged packaging Issue related to building packages, not affecting end users directly. labels May 13, 2024
@licy183 licy183 removed the untriaged label May 13, 2024
@licy183
Copy link
Member

licy183 commented May 13, 2024

abseil-cpp headers need at least c++ 17 to compile, but libosmpbf uses -std=gnu++14.

@twaik
Copy link
Member Author

twaik commented May 13, 2024

What about the protobuf issue?

@licy183
Copy link
Member

licy183 commented May 13, 2024

What about the protobuf issue?

I don't have a computer with me so I can't test it. I'll test it when I get back tonight.

twaik added a commit that referenced this issue May 13, 2024
@twaik
Copy link
Member Author

twaik commented May 13, 2024

It seems like removing protobuf_MODULE_COMPATIBLE and CMAKE_FIND_PACKAGE_PREFER_CONFIG from CMakeLists.txt fixes it. Thank you.

@twaik twaik closed this as completed in 3c7b3d4 May 13, 2024
@Biswa96
Copy link
Contributor

Biswa96 commented May 13, 2024

The workaround from opencv build script also fixed the issue.

TERMUX_PKG_EXTRA_CONFIGURE_ARGS+=" -DProtobuf_PROTOC_EXECUTABLE=$(command -v protoc)"
sed -i 's/COMMAND\sprotobuf::protoc/COMMAND ${Protobuf_PROTOC_EXECUTABLE}/g' $TERMUX_PREFIX/lib/cmake/protobuf/protobuf-generate.cmake

bigbio2002 pushed a commit to bigbio2002/termux-packages that referenced this issue May 13, 2024
Freed-Wu pushed a commit to Freed-Wu/termux-packages that referenced this issue Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Something is not working properly. packaging Issue related to building packages, not affecting end users directly.
Projects
None yet
Development

No branches or pull requests

3 participants