-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm dialog appends yes message when aborted #375
Comments
I think there's a broader discussion to be had here. What should be displayed on abort? Here's what's happening today: For prompts with an initial value, that value is printed.
For those without initial values, nothing is printed.
In the provided example for a This behavior seems unintuitive. I would be in favor of always printing no value on abort for all prompt types like in the |
I agree @joeykilpatrick. Thank you |
Describe the bug
When a prompt is aborted, the confirm message will read "[mesage] ... yes" which is slightly confusing since the value for that prompt will be "empty" (
undefined
).To Reproduce
Steps to reproduce the behavior:
Prompt:
Expected behavior
Either it displays the "no message" since that's closer to how JS would behave for implicit type conversions (
Boolean(undefined) === false
) or add an option to define the message for aborted confirm dialogs.System
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: