Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test_tt_TTOI test #468

Open
JeanKossaifi opened this issue Dec 29, 2022 · 0 comments
Open

Improve test_tt_TTOI test #468

JeanKossaifi opened this issue Dec 29, 2022 · 0 comments

Comments

@JeanKossaifi
Copy link
Member

JeanKossaifi commented Dec 29, 2022

Thanks for adding the TT-TTOI @Lili-Zheng-stat. I fixed the test for MXNet but also realized the test setting is a little strange, the rank is just 1? I think it would make more sense to create a random tensor (with random.random_tt) without noise and check that the relative reconstruction error is lower than a fixed tolerance.

The test also randomly fails with various backends (mostly with dtype float32).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant