You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From the documentation provided here it gives a perception that you can provide all the fields in config-defaults configmap for both pod-template and affinity-assistant-pod-template and can also override three fields (tolerations, nodeSelector, and imagePullSecrets) mentioned in documentation from taskrun and pipelinerun podtemplate which you provide during taskrun and pipeinerun creation.
We should support all field for the default value provided in config-defaults configmap and make documentation more clear.
Use case
Use case is to provide the same podtemplate for both taskrun pods and assifnity assistant pod, so fields like priorityClassName can be provided and all pods get same priority value to schedule.
The text was updated successfully, but these errors were encountered:
Feature request
Right now, we can provide the complete set of field for taskrun pods and also assinity assistant pods using the configmap here default-pod-template and default-affinity-assistant-pod-template
From the documentation provided here it gives a perception that you can provide all the fields in
config-defaults
configmap for bothpod-template
andaffinity-assistant-pod-template
and can also override three fields (tolerations
,nodeSelector
, andimagePullSecrets
) mentioned in documentation fromtaskrun
andpipelinerun
podtemplate which you provide duringtaskrun
andpipeinerun
creation.However, when I tried this feature, it looks like only the three fields (
tolerations
,nodeSelector
, andimagePullSecrets
) from thedefault-affinity-assitant-pod-template
are getting populated in the pod. I tried to figure out the code and see only these three field are getting read by the controller fromdefault-affinity-assistant-pod-template
https://github.com/tektoncd/pipeline/blob/main/pkg/apis/config/default.go#L156 and https://github.com/tektoncd/pipeline/blob/main/pkg/apis/pipeline/pod/affinity_assitant_template.go#L29We should support all field for the default value provided in
config-defaults
configmap and make documentation more clear.Use case
Use case is to provide the same podtemplate for both taskrun pods and assifnity assistant pod, so fields like priorityClassName can be provided and all pods get same priority value to schedule.
The text was updated successfully, but these errors were encountered: