-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in 6.7.2 - undefined index error #699
Comments
nicolaasuni
added a commit
that referenced
this issue
Mar 20, 2024
Please check the version 6.7.3 it should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Upgrading from 6.6.5 to 6.7.2 causes an undefined index error in my test scripts.
The offending code is
$dom[$key-1]
.Using
git bisect
, I have traced the issue to this commit. Removing this change allows the 6.7.2 code to run without error.Debugging shows that when the
$html
parameter is an empty string, then the returned array would otherwise be non-empty. For example, this:We previously returned an array with a key of
0
; we are now returning an empty array. Hence we are getting this error.Elsewhere in the code, I see dependencies on other elements in this array.
I can "fix" the PHP errors by replacing
return array()
in the change withreturn array(array('tag'=>false,'value'=>''))
.However, there may be subtle functional changes that I'm missing.
The text was updated successfully, but these errors were encountered: