Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to extend escapeIllegalChars #64

Open
jelteliekens opened this issue Aug 19, 2020 · 0 comments
Open

Possibility to extend escapeIllegalChars #64

jelteliekens opened this issue Aug 19, 2020 · 0 comments

Comments

@jelteliekens
Copy link

jelteliekens commented Aug 19, 2020

Hi,

The library works great but I have an issue in combination with AWS API Gateway. It is choking on some characters { } ^ because they are not encoded.

So it would be nice to pass an option to the buildQuery function that makes it possible to extends escapeIllegalChars or pass a custom escapeIllegalChars function. I'm also wondering if it is possible to use encodeURIComponent instead of the current implementation? Is there a specific reason why it is not used?

I there an approach you prefer?

I'm happy to help you out by creating a pull request.

Kind regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant