Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The gem is spamming deprecation warnings in tests #91

Open
mdesantis opened this issue Mar 7, 2017 · 7 comments
Open

The gem is spamming deprecation warnings in tests #91

mdesantis opened this issue Mar 7, 2017 · 7 comments

Comments

@mdesantis
Copy link

ruby 2.4.0
rails 5.0.1
acts_as_follower master@c5ac7b9
rspec 3.5.0

When I run rspec I get a lot of these deprecation warnings (a lot is one per test):

DEPRECATION WARNING: Setting custom parent classes is deprecated and will be removed in future versions. (called from parent_class_name at /home/maurizio/.asdf/installs/ruby/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/acts_as_follower-c5ac7b9601c4/lib/acts_as_follower/follower_lib.rb:10)
@brchristian
Copy link
Contributor

@mdesantis I believe #89 should address this.

@georgestam
Copy link

Hi everyone! Not sure if this issue is solved...

ruby 2.4.0
rails 5.0.1
acts_as_follower master@c5ac7b9
rspec 3.5.0

I get the following when runing rspec:

DEPRECATION WARNING: Setting custom parent classes is deprecated and will be removed in future versions. (called from parent_class_name at /usr/local/opt/rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/bundler/gems/acts_as_follower-c5ac7b9601c4/lib/acts_as_follower/follower_lib.rb:10)

@azeemh
Copy link

azeemh commented Aug 4, 2018

i've been getting this error in both rails 5.1.3 and 5.2 projects. attached is the current error it's always the same lines and same error about the deprecated custom parent class name.

ruby 2.4.1
rails 5.1.3 error code:

DEPRECATION WARNING: Setting custom parent classes is deprecated and will be removed in future versions. (called from parent_class_name at /home/azeem/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/bundler/gems/acts_as_follower-c5ac7b9601c4/lib/acts_as_follower/follower_lib.rb:10)
DEPRECATION WARNING: Setting custom parent classes is deprecated and will be removed in future versions. (called from parent_class_name at /home/azeem/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/bundler/gems/acts_as_follower-c5ac7b9601c4/lib/acts_as_follower/follower_lib.rb:10)

@brchristian
Copy link
Contributor

@azeemh I believe #89 should address this.

@theterminalguy
Copy link

theterminalguy commented Jan 8, 2019

Did anyone find a way to get rid of the deprecation warnings, still having the same issues.

ruby '2.3.7'
rails '5.0.0'
rspec '3.5.4' 
acts_as_follower '0.2.1'

Between, I believe my deprecation warning is caused by this I think it should be return DEFAULT_PARENTS if ActsAsFollower.custom_parent_classes.empty?

@brchristian
Copy link
Contributor

@theterminalguy You are correct and I submitted #93 containing this fix. Unfortunately we are still waiting after almost 2 years for #93 to be merged.

@ughstudios
Copy link

@theterminalguy You are correct and I submitted #93 containing this fix. Unfortunately we are still waiting after almost 2 years for #93 to be merged.

Can someone fork this gem and merge your fix into their fork? Then we simply re-release the gem under a new name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants