Map official IEEE 754 rounding mode names to Intl/Temporal names #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add a note for implementors mapping the rounding mode names, which are taken from Intl.NumberFormat, to the official IEEE 754 names. Refer to the default rounding mode by reference rather than directly naming it.
|
Relates to #122 , specifically this comment in the section "Rounding Modes and Implementability". |
nicolo-ribaudo
approved these changes
May 17, 2024
| </tr> | ||
| <tr> | ||
| <td>*"halfExpand"*</td> | ||
| <td>Ties away from zero</td> |
There was a problem hiding this comment.
I think this would be clearer as "Towards the closest value, and ties away for zero" (and similar for halfEven), but given that it's just copied from ECMA-402 it's probably ok to have this shorter version.
jessealama
deleted the
122-map-official-ieee-rounding-mode-names-to-intl-temporal-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.