-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user_id behavior mismatch with OpenSSH #14
Comments
Thanks for pointing this, I'll fix it with the next version which has the support for OpenSSH 8.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
openssh-sk-winhello/src/winhello.c
Lines 273 to 279 in 2cde676
This doesn't match OpenSSH but not for the reasons mentioned in the README.
OpenSSH always uses 32 bytes for
user_id
. I.e.,WEBAUTHN_USER_ENTITY_INFORMATION.cbId
should always be 32 and not be based onstrlen
. If the user didn't specify anything,user_id
will contain 32 zero bytes.https://github.com/openssh/openssh-portable/blob/V_8_9_P1/sk-usbhid.c#L839
The text was updated successfully, but these errors were encountered: