New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Updater][v2] - Show error on non-SSL updater endpoints #1308
Comments
It doesn't silently fail, the error should be there if you open the app from a terminal (unless you're on Windows). We still need to allow non-https protocol in development, otherwise it will be hard to use a localhost to serve your latest.json and updater files so instead I opened a PR to show a warning in development. |
what i mean by silently fail is that tauri will succeed to build. this should be a build error. and wow thanks for the prompt PR! ❤️ |
that' actually a good idea, I will open another PR for it. |
Looks like it is not that easy to make it a build error from the plugin itself, so I guess we will just stick with this warning for now and if more users fall for this, we will make it build error on the CLI. |
no worries, i think normally users will be using ssl for all production updater endpoints, so i don't think this will be too much of a problem, and this issue is open so if people want to find the info they can. thanks a lot! |
Currently, when serving a
latest.json
over anhttps
endpoint, everything works as expected.When moving to a self-hosted solution (ie. NOT github releases), the updater plugin will silently fail if the URI is not
https
.Worst part is, Tauri will not show build errors, and will work in dev mode. However when using a built binary, it will silently fail.
The text was updated successfully, but these errors were encountered: