Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Updater][v2] - Show error on non-SSL updater endpoints #1308

Closed
avvo-na opened this issue May 12, 2024 · 5 comments · Fixed by #1311
Closed

[Updater][v2] - Show error on non-SSL updater endpoints #1308

avvo-na opened this issue May 12, 2024 · 5 comments · Fixed by #1311
Labels
enhancement New feature or request plugin: updater

Comments

@avvo-na
Copy link

avvo-na commented May 12, 2024

Currently, when serving a latest.json over an https endpoint, everything works as expected.

When moving to a self-hosted solution (ie. NOT github releases), the updater plugin will silently fail if the URI is not https.
Worst part is, Tauri will not show build errors, and will work in dev mode. However when using a built binary, it will silently fail.

@amrbashir
Copy link
Member

It doesn't silently fail, the error should be there if you open the app from a terminal (unless you're on Windows). We still need to allow non-https protocol in development, otherwise it will be hard to use a localhost to serve your latest.json and updater files so instead I opened a PR to show a warning in development.

@avvo-na
Copy link
Author

avvo-na commented May 13, 2024

what i mean by silently fail is that tauri will succeed to build. this should be a build error.

and wow thanks for the prompt PR! ❤️

@amrbashir
Copy link
Member

what i mean by silently fail is that tauri will succeed to build. this should be a build error.

that' actually a good idea, I will open another PR for it.

@amrbashir
Copy link
Member

Looks like it is not that easy to make it a build error from the plugin itself, so I guess we will just stick with this warning for now and if more users fall for this, we will make it build error on the CLI.

@avvo-na
Copy link
Author

avvo-na commented May 25, 2024

no worries, i think normally users will be using ssl for all production updater endpoints, so i don't think this will be too much of a problem, and this issue is open so if people want to find the info they can. thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin: updater
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants