-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notification.subscribe for Network.ETHEREUM_GOERLI does not append testnetType=
query param
#1046
Comments
Can you please @kazykenov provide information on how you created the notification via Tatum SDK? |
So, here is the code snippet that your documentation provides on how to create a subscription:
Now for the above example use |
Describe the bug
Creating a subscription through Tatum SDK for Ethereum testnet does not append
testnetType=
query param to the outgoing request. Hence notification with nochain
field in the root level is created, which is no longer triggered for any testnet transactionTo Reproduce
Steps to reproduce the behavior:
Network.ETHEREUM_GOERLI
testnetType=ethereum-goerli
https://dashboard.tatum.io/api/sdk/notifications . The subscription created by step 1 does not have
"chain": "ethereum-goerli",
fieldExpected behavior
https://github.com/tatumio/tatum-js/blob/master/src/service/notification/subscribe.ts:38 should append
testnetType
query param how https://apidoc.tatum.io/tag/Notification-subscriptions#operation/createSubscription does itScreenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: