Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and refactor #16

Open
leerob opened this issue Nov 23, 2022 · 3 comments
Open

Update dependencies and refactor #16

leerob opened this issue Nov 23, 2022 · 3 comments

Comments

@leerob
Copy link

leerob commented Nov 23, 2022

A few things to note:

  • I'm not sure we need Redux here, the other examples don't have it
  • Let's try to be 1:1 on CSS solutions - others are using Tailwind CSS, so use that
  • To be a more accurate comparison with other frameworks server-first, I recommend exploring the app directory
  • I would avoid ejecting the webpack plugin
  • Can probably remove a lot of the custom react-* packages added, which are increasing client JS, in comparison to other framework examples which aren't doing this
@leerob
Copy link
Author

leerob commented Nov 26, 2022

CleanShot 2022-11-26 at 15 52 31@2x

Maybe worth exploring this?

https://next-movie.transitivebullsh.it/

@addyosmani
Copy link
Member

As it turns out, I've been re-reading the source to https://next-movie.transitivebullsh.it/ this weekend and fully agree that a refactor that accounts for the points you listed would make sense. My ideal for this implementation would be using Next.js 13 with AppDir.

I see that while the OG implem you linked to is using AppDir, the author appears to be considering reverting back to pages: transitive-bullshit/next-movie#1. @leerob if we ignore the theming issue, do you have insight into whether I should wait for vercel/next.js#43159 to be addressed? We can of course just opt for a pages implementation in the refactor, but would be great to actually use AppDir.

@addyosmani
Copy link
Member

I've gone ahead and made sure we are at least linking to the above implementation as part of the community alternatives section in the TasteJS Movies header over on the main site: https://tastejs.com/movies/

image

@ transitive-bullshit fyi. I really do like the implementation you wrote up btw. The choices of navigation modes was cool and I also thought it was an interesting idea to support GitHub (vs TMDB) auth for the wishlist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants