New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WorkerInterface was removed in master #544
Labels
help wanted
Extra attention is needed
Comments
@danielytics, would you mind submitting a PR to get this back? I was planning to introduce a more unified interface, but during the interim, we can recover it. |
As long as there's a solution planned, I'm happy enough to keep using the latest version that has it. But I will submit a PR for it over the coming days 👍 |
That will be great! Thank you for the help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
WorkerInterface
class was removed from master when the exception handling logic was added, however, (the broken) exception handling wasn't the only purpose forWorkerInterface
: I've been usingtf::WorkerInterface::scheduler_prologue
to set thread names for logging and affinity to pin threads to cores. It looks like I'm not the only person using WorkerInterface.Please consider bringing it back (although obviously the exception parameter is not required in the epilogue function anymore).
The text was updated successfully, but these errors were encountered: