Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVC 2022 compilation error in 3.6.0 #510

Open
lhog opened this issue Sep 15, 2023 · 0 comments
Open

MSVC 2022 compilation error in 3.6.0 #510

lhog opened this issue Sep 15, 2023 · 0 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@lhog
Copy link

lhog commented Sep 15, 2023

https://gist.github.com/lhog/fd82bf5e36cea94ef50b1701a2c7ba53

causes error:

error C4146: unary minus operator applied to unsigned type, result still unsigned
..... taskflow\algorithm\sort.hpp	42

Basically it dislikes -cacheline_size in https://github.com/taskflow/taskflow/blob/v3.6.0/taskflow/algorithm/sort.hpp#L42

I believe it can be replaced with:
ip = (ip + cacheline_size - 1) & ~(cacheline_size - 1);

But I'm not entirely sure.
@tsung-wei-huang tsung-wei-huang added help wanted Extra attention is needed question Further information is requested labels Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lhog @tsung-wei-huang