Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mermaid dump support #272

Open
IceflowRE opened this issue Jan 14, 2021 · 2 comments · May be fixed by #273
Open

Mermaid dump support #272

IceflowRE opened this issue Jan 14, 2021 · 2 comments · May be fixed by #273
Labels
enhancement New feature or request

Comments

@IceflowRE
Copy link

IceflowRE commented Jan 14, 2021 •
edited

Currently only GraphViz dump is supported.
I would like to request a dump support for the Mermaid format.

  1. How should it be implemented, to support different formats? There are no parameter to choose which output you want.
  2. Should the look of the Mermaid dump look close/ identical to the GraphViz one?

As it seems to be an easy start to get in touch with the taskflow code, i would be interested in doing this.
@tsung-wei-huang
Copy link
Member

Hi @IceflowRE , this is an excellent idea. The dump method is defined in the taskflow class here. I think we may add another parameter to the end indicating the format?

tf::Taskflow::dump(std::ostream& os, GraphViz)
tf::Taskflow::dump(std::ostream& os, Mermaid)

I will be happy if you are willing to contribute to this.

@IceflowRE IceflowRE linked a pull request Jan 17, 2021 that will close this issue
Open
@IceflowRE
Copy link
Author

@tsung-wei-huang may you take a look if the initial idea would be ok?

@tsung-wei-huang tsung-wei-huang added the enhancement New feature or request label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Add Mermaid dump support IceflowRE/taskflow
2 participants
@IceflowRE @tsung-wei-huang