-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automatically choose taskcluster proxy port in generic worker #6953
Comments
This is a nice idea. One thing to be careful of is that some tasks historically used |
@jcristau also pointed out, workers could steal ports that tasks wanted to use, but perhaps that is acceptable fallout and can be worked around. I assume the request here is only to change default behavior when no port is specified. Presumably, the config property can be retained, so that an explicit value can be set to overwrite the default value. |
At the moment, the taskcluster proxy port must be specified in the generic worker configuration. As far as I can tell, there's nothing external to generic worker that needs to know this port, which means it could potentially probe for a bindable port itself instead. This would help avoid misconfigurations like we found in https://bugzilla.mozilla.org/show_bug.cgi?id=1889647.
The text was updated successfully, but these errors were encountered: